Sure, this is a good idea. Acked-by: Corey Minyard <[email protected]>
Note that nmi_panic() came in commit 1717f2096b5 (panic, x86: Fix re-entrance problem due to panic on NMI) and then the regs field was added in the commit you reference. Do you want me to add this to the IPMI queue or do you have another way to get this patch into the kernel? -corey On 02/29/2016 07:50 PM, Hidehiro Kawai wrote:
commit 58c5661f2144 ("panic, x86: Allow CPUs to save registers even if looping in NMI context") introduced nmi_panic() which prevents concurrent/recursive execution of panic(). It also saves registers for the crash dump on x86. ipmi_watchdog driver can call panic() from NMI handler, so replace it with nmi_panic(). Signed-off-by: Hidehiro Kawai <[email protected]> Cc: Corey Minyard <[email protected]> Cc: [email protected] --- drivers/char/ipmi/ipmi_watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c index 096f0ce..4facc75 100644 --- a/drivers/char/ipmi/ipmi_watchdog.c +++ b/drivers/char/ipmi/ipmi_watchdog.c @@ -1140,7 +1140,7 @@ ipmi_nmi(unsigned int val, struct pt_regs *regs) the timer. So do so. */ pretimeout_since_last_heartbeat = 1; if (atomic_inc_and_test(&preop_panic_excl)) - panic(PFX "pre-timeout"); + nmi_panic(regs, PFX "pre-timeout"); }return NMI_HANDLED;
