On Wed, Mar 2, 2016 at 2:50 PM, Toshi Kani <[email protected]> wrote: > insert_resource() and remove_resouce() are called by producers > of resources, such as FW modules and bus drivers. These modules > may be implemented as loadable modules. > > Add device-managed implementaions of insert_resource() and > remove_resouce() functions. > > Signed-off-by: Toshi Kani <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Dan Williams <[email protected]> > --- > include/linux/ioport.h | 5 +++ > kernel/resource.c | 69 > ++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 74 insertions(+) > > diff --git a/include/linux/ioport.h b/include/linux/ioport.h > index 8017b8b..3580038 100644 > --- a/include/linux/ioport.h > +++ b/include/linux/ioport.h > @@ -259,6 +259,11 @@ extern struct resource * __devm_request_region(struct > device *dev, > > extern void __devm_release_region(struct device *dev, struct resource > *parent, > resource_size_t start, resource_size_t n); > + > +extern int devm_insert_resource(struct device *dev, struct resource *root, > + struct resource *new); > +extern void devm_remove_resource(struct device *dev, struct resource *old); > + > extern int iomem_map_sanity_check(resource_size_t addr, unsigned long size); > extern int iomem_is_exclusive(u64 addr); > > diff --git a/kernel/resource.c b/kernel/resource.c > index effb6ee..b1a3394 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -1449,6 +1449,75 @@ void __devm_release_region(struct device *dev, struct > resource *parent, > EXPORT_SYMBOL(__devm_release_region); > > /* > + * Remove function for devm_insert_resource() and devm_remove_resource(). > + */ > +static void devm_resource_remove(struct device *dev, void *ptr) > +{ > + struct resource **r = ptr; > + > + remove_resource(*r); > +} > +
Maybe call this __devm_remove_resource? I think this makes it clearer that it is a private helper function. I was initially confused about the difference between devm_resource_remove and devm_remove_resource.
