On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote: > From: Suravee Suthikulpanit <[email protected]> > > First, this patch move arch/x86/events/amd/iommu.h to > arch/x86/include/asm/perf/amd/iommu.h so that we easily include > it in both perf-amd-iommu and amd-iommu drivers. > > Then, we consolidate declaration of AMD IOMMU performance counter > APIs into one file.
These seem two independent thingies; should this therefore not be 2 patches? > Reviewed-by: Joerg Roedel <[email protected]> > Signed-off-by: Suravee Suthikulpanit <[email protected]> > --- > arch/x86/events/amd/iommu.c | 2 +- > arch/x86/events/amd/iommu.h | 40 --------------------------------- > arch/x86/include/asm/perf/amd/iommu.h | 42 > +++++++++++++++++++++++++++++++++++ That seems somewhat excessive. Not only do you create arch/x86/include/asm/perf/ you then put another directory on top of that.

