On 05/03/2016 at 23:38:50 +0100, Paul Cercueil wrote :
> + if (of_device_is_system_power_controller(pdev->dev.of_node)) {
> + if (!pm_power_off) {
> + /* Default: 60ms */
> + rtc->reset_pin_assert_time = 60;
> + device_property_read_u32(&pdev->dev,
It is probably more efficient to use of_property_read_u32 directly. Any
particular reason to use device_property_read_u32?
> + } else {
> + dev_err(&pdev->dev,
> + "Poweroff handler already present!\n");
I'm not found of that alignement, it is probably better to let the
string go over 80 chars. checkpatch will not complain.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
