> -----Original Message----- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: 28 March, 2016 13:09 > To: Tirdea, Irina; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Hartmut Knaack; Lars-Peter Clausen; Peter > Meerwald; Markus Pargmann > Subject: Re: [PATCH 1/1] iio: accel: bmc150: remove unused definition > > On 24/03/16 09:00, Irina Tirdea wrote: > > bmc150_i2c_regmap_conf is defined in bmc150-accel-core.c, but > > never used here. The definition is needed in bmc150-accel-i2c.c, > > where it is again defined. > > > > Remove the unnecessary definition of bmc150_i2c_regmap_conf from > > bmc150-accel-core.c and update the one from bmc150-accel-i2c.c > > to contain all fields. > > > > Signed-off-by: Irina Tirdea <irina.tir...@intel.com> > Silly question. Why isn't it shared between the i2c and spi drivers? > Looks to be the same in both cases (as we'd expect from regmap most > of the time!). I think it would be better to share it. >
Good point. I'll keep the definition in the core file and share the regmap with the rest. Thanks, Irina
