On Wed, 2016-03-30 at 07:50PM, Joakim Tjernlund wrote:
> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernl...@infinera.com]
> Sent: Wednesday, March 30, 2016 7:50 PM
> To: da...@davemloft.net; Qiang Zhao <qiang.z...@nxp.com>
> Cc: linuxppc-...@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo Xie
> <xiaobo....@nxp.com>; o...@buserror.net; gre...@linuxfoundation.org;
> a...@linux-foundation.org; net...@vger.kernel.org
> Subject: Re: [PATCH 4/5] fsl/qe: Add QE TDM lib
>
> On Wed, 2016-03-30 at 16:50 +0800, Zhao Qiang wrote:
> > QE has module to support TDM, some other protocols supported by QE are
> > based on TDM.
> > add a qe-tdm lib, this lib provides functions to the protocols using
> > TDM to configurate QE-TDM.
> >
> > Signed-off-by: Zhao Qiang <qiang.z...@nxp.com>
> > + utdm->siram_entry_id = val;
> > +
> > + set_si_param(utdm, ut_info);
> > +
> > + np2 = of_find_compatible_node(NULL, NULL, "fsl,t1040-qe-si");
>
> fsl,t1040-qe-si only? What about mpc83xx?
> I recall QE is a little bit different compared to T1040 or will this
> work(including
> the hdlc driver) on 83xx as well?
The " fsl,t1040-qe-si " is new added to dts and bindings, it is required to
have SoC specific compatible strings.
mpc83xx will not use qe-si node. If there will be other soc useing qe-si, "
fsl,t1040-qe-si " will follow the soc specific compatible,
like :
si1: si@700 {
compatible = "fsl,ls1043-qe-si", "fsl,t1040-qe-si";
reg = <0x700 0x80>;
};
Best Regards
Zhao Qiang
