On 08/04/16 14:42, Christoffer Dall wrote:
On Mon, Apr 04, 2016 at 05:26:13PM +0100, Suzuki K Poulose wrote:
-static void clear_pud_entry(struct kvm *kvm, pud_t *pud, phys_addr_t addr) +static void clear_stage2_pud_entry(struct kvm *kvm, pud_t *pud, phys_addr_t addr) { - pmd_t *pmd_table = pmd_offset(pud, 0); - VM_BUG_ON(pud_huge(*pud)); - pud_clear(pud); + pmd_t *pmd_table __maybe_unused = stage2_pmd_offset(pud, 0);The __maybe_unused are slightly ugly, so it may be nicer to create the stage2_pmd_free() as static inline's if they're defined to do nothing instead.
Sure, we could do that for stage2. However, we will need to fix the host helpers as well for making such a change in the _hyp version (for 16K + 36bit VA).
Acked-by: Christoffer Dall <[email protected]>
Thanks Suzuki
