On Fri, Apr 15, 2016 at 11:59 AM, Stephen Boyd <[email protected]> wrote: > From: Stephen Boyd <[email protected]> > Subject: [PATCH] Input: pmic8xxx-pwrkey: Fix algorithm for converting trigger > delay > > The trigger delay algorithm that converts from microseconds to > the register value looks incorrect. According to most of the PMIC > documentation, the equation is > > delay (Seconds) = (1 / 1024) * 2 ^ (x + 4) > > except for one case where the documentation looks to have a > formatting issue and the equation looks like > > delay (Seconds) = (1 / 1024) * 2 x + 4 > > Most likely this driver was written with the improper > documentation to begin with. According to the downstream sources > the valid delays are from 2 seconds to 1/64 second, and the > latter equation just doesn't make sense for that. Let's fix the > algorithm and the range check to match the documentation and the > downstream sources. > > Reported-by: Bjorn Andersson <[email protected]> > Cc: John Stultz <[email protected]> > Fixes: 92d57a73e410 ("input: Add support for Qualcomm PMIC8XXX power key") > Signed-off-by: Stephen Boyd <[email protected]>
This works great for me, and lets me zap the pwrkey node in my dts. Tested-by: John Stultz <[email protected]> I'll also send an updated variant of my patch that only removes the gpio key. thanks! -john
