----- Original Message ----- From: Andy Shevchenko [mailto:[email protected]] To: Maarten Brock [mailto:[email protected]] Cc: Andy Shevchenko [mailto:[email protected]], Bryan O'Donoghue [mailto:[email protected]], Peter Hurley [mailto:[email protected]], [email protected] [mailto:[email protected]], Vinod Koul [mailto:[email protected]], [email protected] [mailto:[email protected]], dmaengine [mailto:[email protected]], Greg Kroah-Hartman [mailto:[email protected]], Puustinen, Ismo [mailto:[email protected]], Heikki Krogerus [mailto:[email protected]] Sent: Fri, 06 May 2016 13:38:44 +0200 Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface
> On Fri, May 6, 2016 at 2:20 PM, Maarten Brock <[email protected]> wrote: > >> > > > >> > > + bool polarity; > >> > So this variable is not very intuitively named. > >> > >> There is a help above. This is a property of the Synopsys DesignWare DMA > >> engine. Anyone familiar with datasheet easily understands this. > >> > >> > > >> > You end up setting somepointer->polarity = true; in a later patch. > >> > > >> > Since you're respining a V4 I'd suggest a name that describes a little > >> > bit better than polarity. Setting polarity = true is a little bit > >> > liked being asked "you you like ice-cream or apple pie" and then > >> > saying "yes please". > >> > >> It's about handshake interface polarity, so, what about hs_polarity? > > > > So it means: handshake has polarity (true) or handshake has no polarity > > (omnidirectional?) (false), right? > > It means that handshake polarity _signal_ is inverted (true) or > default (false) in terms of hardware gates. Would it not be better then to name it handshake_inverted ? That is something you can ask and answer with true or false. Maarten > -- > With Best Regards, > Andy Shevchenko >
