Hi Mauro and David, On Wed, May 11, 2016 at 05:38:23PM -0300, Mauro Carvalho Chehab wrote: > Hi David, > > Em Wed, 11 May 2016 20:05:22 +0100 > David R <[email protected]> escreveu: > > > On 11/05/16 19:47, David R wrote: > > > Hi > > > > > > Please consider applying the attached patch (or something like it) to > > > V4L2, and whatever is appropriate to the mainstream kernel. Without this > > > my media server crashes and burns at boot. > > > > > > See https://lkml.org/lkml/2016/5/7/88 for more details > > > > > > Thanks > > > David > > > > > I see the offending patch was reverted earlier today. My box is fine > > with my (more simple) alternative, but your call. > > Yes, I noticed the bug earlier today, while testing a DVB device. > As this affects 2 stable releases plus the upcoming Kernel 4.6, > I decided to just revert it for now, while we don't solve the > issue. > > Your patch looks good. So, eventually it will be merged on a new > version of this patch, after we test it properly.
Indeed vb2_core_dqbuf() is called with pb == NULL in file I/O, which was unfortunately missed until now. The proposed fix looks good to me. -- Kind regards, Sakari Ailus e-mail: [email protected] XMPP: [email protected]
