On Fri, Jun 10, 2016 at 06:39:26PM +0200, Vlastimil Babka wrote: > > @@ -5944,10 +5944,10 @@ static void __paginginit free_area_init_core(struct > > pglist_data *pgdat) > > zone->min_slab_pages = (freesize * sysctl_min_slab_ratio) / 100; > > #endif > > zone->name = zone_names[j]; > > + zone->zone_pgdat = pgdat; > > spin_lock_init(&zone->lock); > > - spin_lock_init(&zone->lru_lock); > > + spin_lock_init(zone_lru_lock(zone)); > > This means the same lock will be inited MAX_NR_ZONES times. Peterz told > me it's valid but weird. Probably better to do it just once, in case > lockdep/lock debugging gains some checks for that? >
Good point and it's an easy fix. -- Mel Gorman SUSE Labs
