On Thu, 2016-06-23 at 10:59PM, David Miller wrote: > -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, June 23, 2016 10:59 PM > To: Qiang Zhao <qiang.z...@nxp.com> > Cc: o...@buserror.net; linux-kernel@vger.kernel.org; net...@vger.kernel.org; > Xiaobo Xie <xiaobo....@nxp.com> > Subject: Re: [PATCH] Maxim/driver: Add driver for maxim ds26522 > > From: Zhao Qiang <qiang.z...@nxp.com> > Date: Thu, 23 Jun 2016 09:09:45 +0800 > > > +MODULE_DESCRIPTION(DRV_DESC); > > There is no definition of DRV_DESC, so this makes it look like you didn't even > compile this driver.
I really, really compiled this driver. Thank you for your review and comments. I will modify it the next version. [zhaoqiang@titan:~/upstream/linux]$ll drivers/net/wan/slic_ds26522.o -rw-r--r-- 1 zhaoqiang klocwork 153288 Jun 22 15:48 drivers/net/wan/slic_ds26522.o [zhaoqiang@titan:~/upstream/linux]$date Fri Jun 24 09:42:16 CST 2016 -Zhao Qiang BR
