Commit-ID:  4a35b3497c413de8b409f9d75700eeb4772b21b8
Gitweb:     http://git.kernel.org/tip/4a35b3497c413de8b409f9d75700eeb4772b21b8
Author:     Taeung Song <[email protected]>
AuthorDate: Thu, 23 Jun 2016 23:14:32 +0900
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 23 Jun 2016 17:23:00 -0300

perf config: Reimplement show_config() using config_set__for_each

Recently config_set__for_each got added.  In order to let show_config()
be short and clear, rewrite this function using it.

Signed-off-by: Taeung Song <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Wang Nan <[email protected]>
Link: 
http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/builtin-config.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index cfd1036..e4207a2 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -37,23 +37,16 @@ static int show_config(struct perf_config_set *set)
 {
        struct perf_config_section *section;
        struct perf_config_item *item;
-       struct list_head *sections;
 
        if (set == NULL)
                return -1;
 
-       sections = &set->sections;
-       if (list_empty(sections))
-               return -1;
-
-       list_for_each_entry(section, sections, node) {
-               list_for_each_entry(item, &section->items, node) {
-                       char *value = item->value;
+       perf_config_set__for_each_entry(set, section, item) {
+               char *value = item->value;
 
-                       if (value)
-                               printf("%s.%s=%s\n", section->name,
-                                      item->name, value);
-               }
+               if (value)
+                       printf("%s.%s=%s\n", section->name,
+                              item->name, value);
        }
 
        return 0;

Reply via email to