On Monday, August 01, 2016 10:07:58 AM Thomas Garnier wrote: > ***Background: > KASLR memory randomization for x86_64 was added when KASLR did not support > hibernation. Now that it does, some changes are needed. > > ***Problems that needed solving: > Hibernation was failing on reboot with a GP fault when > CONFIG_RANDOMIZE_MEMORY was enabled. Two issues were identified. > > The original fault was due to a wrong physical address assigned to cr3. The > problem was introduced with __PAGE_OFFSET becoming a global variable when > randomized. The fix uses a define to use the glbobal or immediate value based > on config settings. > > The second isssue was that the temporary page table mapping did not support > virtual addresses not aligned on PGD level. KASLR memory randomization will > generated a random address aligned on PUD level. The fix correctly calculates > the offset on all levels of the temporary page table. > > ***Parts: > - 01/02: Support unaligned addresses (second issue) > - 02/02: Fix __PAGE_OFFSET usage on assembly (first issue)
Thanks a lot for taking care of this! Patch [2/2] looks good to me, but I'd to the [1/2] differently (more details will follow). Thanks, Rafael
