I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/pci/solo6x10/solo6x10-p2m.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-p2m.c b/drivers/media/pci/solo6x10/solo6x10-p2m.c index 8c84846..11f0ec0 100644 --- a/drivers/media/pci/solo6x10/solo6x10-p2m.c +++ b/drivers/media/pci/solo6x10/solo6x10-p2m.c @@ -25,12 +25,12 @@ #include "solo6x10.h" static int multi_p2m; -module_param(multi_p2m, uint, 0644); +module_param(multi_p2m, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(multi_p2m, "Use multiple P2M DMA channels (default: no, 6010-only)"); static int desc_mode; -module_param(desc_mode, uint, 0644); +module_param(desc_mode, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(desc_mode, "Allow use of descriptor mode DMA (default: no, 6010-only)"); -- 2.9.2
