I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/block/sx8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c index ba4bfe9..e2b6c08 100644 --- a/drivers/block/sx8.c +++ b/drivers/block/sx8.c @@ -66,7 +66,7 @@ MODULE_VERSION(DRV_VERSION); * but problems seem to occur when you exceed ~30, even on newer hardware. */ static int max_queue = 1; -module_param(max_queue, int, 0444); +module_param(max_queue, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_queue, "Maximum number of queued commands. (min==1, max==30, safe==1)"); -- 2.9.2
