Baole Ni <[email protected]> writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <[email protected]> > Signed-off-by: Baole Ni <[email protected]> > --- > drivers/usb/phy/phy-tahvo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c > index ab5d364..a297861 100644 > --- a/drivers/usb/phy/phy-tahvo.c > +++ b/drivers/usb/phy/phy-tahvo.c > @@ -73,7 +73,7 @@ static ssize_t vbus_state_show(struct device *device, > struct tahvo_usb *tu = dev_get_drvdata(device); > return sprintf(buf, "%s\n", tu->vbus_state ? "on" : "off"); > } > -static DEVICE_ATTR(vbus, 0444, vbus_state_show, NULL); > +static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, vbus_state_show, NULL); > > static void check_vbus_state(struct tahvo_usb *tu) > { > @@ -318,7 +318,7 @@ static ssize_t otg_mode_store(struct device *device, > > return r; > } > -static DEVICE_ATTR(otg_mode, 0644, otg_mode_show, otg_mode_store); > +static DEVICE_ATTR(otg_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, > otg_mode_show, otg_mode_store);
line too long -- balbi
signature.asc
Description: PGP signature
