I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/platform/x86/wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index ceeb8c1..d3dc738 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -81,12 +81,12 @@ struct wmi_block { #define ACPI_WMI_EVENT 0x8 /* GUID is an event */ static bool debug_event; -module_param(debug_event, bool, 0444); +module_param(debug_event, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug_event, "Log WMI Events [0/1]"); static bool debug_dump_wdg; -module_param(debug_dump_wdg, bool, 0444); +module_param(debug_dump_wdg, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug_dump_wdg, "Dump available WMI interfaces [0/1]"); -- 2.9.2
