I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/phy/phy-xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-xgene.c b/drivers/phy/phy-xgene.c index 385362e..f934d7f 100644 --- a/drivers/phy/phy-xgene.c +++ b/drivers/phy/phy-xgene.c @@ -557,7 +557,7 @@ struct xgene_phy_ctx { */ static int preA3Chip; MODULE_PARM_DESC(preA3Chip, "Enable pre-A3 chip support (1=enable 0=disable)"); -module_param_named(preA3Chip, preA3Chip, int, 0444); +module_param_named(preA3Chip, preA3Chip, int, S_IRUSR | S_IRGRP | S_IROTH); static void sds_wr(void __iomem *csr_base, u32 indirect_cmd_reg, u32 indirect_data_reg, u32 addr, u32 data) -- 2.9.2
