I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/infiniband/hw/cxgb4/mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c index 55d0651..73fccdc 100644 --- a/drivers/infiniband/hw/cxgb4/mem.c +++ b/drivers/infiniband/hw/cxgb4/mem.c @@ -39,7 +39,7 @@ #include "iw_cxgb4.h" int use_dsgl = 0; -module_param(use_dsgl, int, 0644); +module_param(use_dsgl, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)"); #define T4_ULPTX_MIN_IO 32 @@ -48,7 +48,7 @@ MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)"); #define C4IW_INLINE_THRESHOLD 128 static int inline_threshold = C4IW_INLINE_THRESHOLD; -module_param(inline_threshold, int, 0644); +module_param(inline_threshold, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(inline_threshold, "inline vs dsgl threshold (default=128)"); static int mr_exceeds_hw_limits(struct c4iw_dev *dev, u64 length) -- 2.9.2
