Commit-ID: ce92834407a465c25c0be1a4a0339c625e44c4db Gitweb: http://git.kernel.org/tip/ce92834407a465c25c0be1a4a0339c625e44c4db Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Fri, 29 Jul 2016 11:54:35 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 29 Jul 2016 11:54:35 -0300
perf target: str_error_r() always returns the buffer it receives So no need for checking if it uses the strerror_r() GNU variant error reporting mechanism, i.e. if it returns a pointer to a immutable string internal to glibc. Cc: Adrian Hunter <[email protected]> Cc: David Ahern <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Wang Nan <[email protected]> Fixes: c8b5f2c96d1b ("tools: Introduce str_error_r()") Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> --- tools/perf/util/target.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/perf/util/target.c b/tools/perf/util/target.c index 8cdcf46..21c4d9b 100644 --- a/tools/perf/util/target.c +++ b/tools/perf/util/target.c @@ -122,11 +122,7 @@ int target__strerror(struct target *target, int errnum, BUG_ON(buflen == 0); if (errnum >= 0) { - const char *err = str_error_r(errnum, buf, buflen); - - if (err != buf) - scnprintf(buf, buflen, "%s", err); - + str_error_r(errnum, buf, buflen); return 0; }
