[Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/08/2016 (Fri 13:56) Lee Jones wrote:
> On Wed, 06 Jul 2016, Paul Gortmaker wrote: > > > [Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/07/2016 > > (Tue 11:18) Laxman Dewangan wrote: > > > > > > > > On Tuesday 05 July 2016 06:55 AM, Paul Gortmaker wrote: > > > >The Kconfig currently controlling compilation of this code is: > > > > > > > >drivers/mfd/Kconfig:config MFD_AS3722 > > > >drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC" > > > > > > > > > > > > > Should we convert this to as "tristate" so that it can be built as module > > > also. > > > > Seems to compile and modpost w/o missing symbols as tristate: > > > > paul@yow-builder:~/git/linux-head$ ls -l ../arm-build/drivers/mfd/as3722* > > -rw-rw-r-- 1 paul paul 13010 Jul 6 12:30 ../arm-build/drivers/mfd/as3722.ko > > -rw-rw-r-- 1 paul paul 1937 Jul 6 12:28 > > ../arm-build/drivers/mfd/as3722.mod.c > > -rw-rw-r-- 1 paul paul 3820 Jul 6 12:29 > > ../arm-build/drivers/mfd/as3722.mod.o > > -rw-rw-r-- 1 paul paul 11292 Jul 6 12:13 ../arm-build/drivers/mfd/as3722.o > > paul@yow-builder:~/git/linux-head$ > > > > ...so I'll drop this patch in favour of the one line tristate conversion in > > v2. > > Did you ever get around to submitting a v2? I made the v2 (as per above build stats) but never sent it out since I wasn't sure if mfd wanted a complete resend (like davem/linux-net) or just resends of the revised content... and then I never came back to it. Here is the one line trivial patch. If you want to punt this to 4.9 given the current timing wrt. the merge window, feel free to do so; and/or I can re-send it myself with other pending 4.9 content I have. Thanks, Paul. -- From 97a056efc6404f612ab83ea900e1aae2cbcac4a6 Mon Sep 17 00:00:00 2001 From: Paul Gortmaker <[email protected]> Date: Tue, 8 Sep 2015 20:53:04 -0400 Subject: [PATCH] mfd: as3722: convert MFD_AS3722 from bool to tristate The Kconfig currently controlling compilation of this code is: drivers/mfd/Kconfig:config MFD_AS3722 drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC" ...meaning that it currently is not being built as a module by anyone. In response to an earlier patch set suggesting removal of the unused modular code, Laxman suggested that this driver be instead moved to tristate. We do that here, and confirm it can build and modpost as a tristate. However there remains to be runtime testing in order to ensure this change is 100% functional for "=m". Cc: Samuel Ortiz <[email protected]> Cc: Lee Jones <[email protected]> Cc: Florian Lobmaier <[email protected]> Cc: Laxman Dewangan <[email protected]> Signed-off-by: Paul Gortmaker <[email protected]> --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 2d1fb6420592..0a0ac8c8c14c 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -50,7 +50,7 @@ config MFD_AS3711 Support for the AS3711 PMIC from AMS config MFD_AS3722 - bool "ams AS3722 Power Management IC" + tristate "ams AS3722 Power Management IC" select MFD_CORE select REGMAP_I2C select REGMAP_IRQ -- 2.8.4
