On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote: > This patch add the IMEM syscon memory region to the DT, > as well as addds support for the magic reboot reason > values that are written to the address for each mode. >
This looks good, double checked the addresses and magics. But I think you should move the entire thing to qcom-apq8064.dtsi, as this is common to the base platform. And I would prefer if you updated the subject prefix... With the move and subject update: Reviewed-by: Bjorn Andersson <bjorn.anders...@linaro.org> Regards, Bjorn > Cc: Rob Herring <robh...@kernel.org> > Cc: Andy Gross <agr...@codeaurora.org> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: Stephen Boyd <stephen.b...@linaro.org> > Cc: linux-arm-...@vger.kernel.org > Cc: devicet...@vger.kernel.org > Signed-off-by: John Stultz <john.stu...@linaro.org> > --- > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts > b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts > index 7b05f07..ff856c3 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts > @@ -272,5 +272,19 @@ > vqmmc-supply = <&pm8921_s4>; > }; > }; > + > + imem@2a03f000 { > + compatible = "syscon", "simple-mfd"; > + reg = <0x2a03f000 0x1000>; > + > + reboot-mode { > + compatible = "syscon-reboot-mode"; > + offset = <0x65c>; > + > + mode-normal = <0x77665501>; > + mode-bootloader = <0x77665500>; > + mode-recovery = <0x77665502>; > + }; > + }; > }; > }; > -- > 1.9.1 >