Em Thu, Aug 11, 2016 at 11:49:00AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Aug 11, 2016 at 06:51:39PM +0530, Ravi Bangoria escreveu: > > On Thursday 11 August 2016 05:20 PM, Arnaldo Carvalho de Melo wrote: > > > Can you please provide a better explanation? I had to look at the patch > > > to understand what it was fixing, and then the patch adds LIBELF_SUPPORT > > > ifdefs while the patch description, talks about DWARF.
> > Yes. Explanation could have been better. Apologies for that. > > arch__post_process_probe_trace_events() calls get_target_map() to prepare > > symbol table. get_target_map() is defined inside util/probe-event.c. > > probe-event.c will only get included in perf binary if CONFIG_LIBELF is set. > > Hence arch__post_process_probe_trace_events() needs to be defined inside > > #ifdef HAVE_LIBELF_SUPPORT to solve compilation error. > > Please let me know if any doubts. > Thanks, that is better, will add this there. But the patch his mangled, you use: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 Please read Documentation/email-clients.txt, there are ways to fix the sending of patches. I fixed it up this time, there were two instances like: [acme@jouet linux]$ patch -p1 < /wb/1.patch patching file tools/perf/arch/powerpc/util/sym-handling.c patch: **** malformed patch at line 33: @@ -118,5 +119,6 @@ void arch__post_process_probe_trace_events(struct it breaks down long lines ;-\ [acme@jouet linux]$ - Arnaldo