On Mon, Aug 29, 2016 at 12:10:20PM -0700, Josh Triplett wrote: > On Mon, Aug 29, 2016 at 10:06:18PM +0300, Dan Carpenter wrote: > > I would like a couple changes which you know already: > > > > 1) Get rid of PREFER_ETHER_ADDR_COPY and similar because the people who > > send checkpatch.pl fixes aren't qualified to say when it's legal or not > > so they sometimes introduce bugs. > > I do think we should have *something* that catches such things. > Perhaps not checkpatch.pl, though. Perhaps a compiler plugin that > generates additional warnings, and can perhaps use more global > information to determine legality?
Perhaps. But that shouldn't delay us from deleting this code which just encourages newbies to introduce bugs. regards, dan carpenter
