Hi John, Thank you for the patch.
On Monday 29 Aug 2016 16:41:33 John Stultz wrote: > From: Archit Taneja <[email protected]> > > This patch moves the adv7511 data structure to header file so that the > audio driver file could use it. Actually it doesn't, the data structure is already in the header file. > Cc: David Airlie <[email protected]> > Cc: Archit Taneja <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Wolfram Sang <[email protected]> > Cc: Srinivas Kandagatla <[email protected]> > Cc: "Ville Syrjälä" <[email protected]> > Cc: Boris Brezillon <[email protected]> > Cc: Andy Green <[email protected]> > Cc: Dave Long <[email protected]> > Cc: Guodong Xu <[email protected]> > Cc: Zhangfei Gao <[email protected]> > Cc: Mark Brown <[email protected]> > Cc: Lars-Peter Clausen <[email protected]> > Cc: Jose Abreu <[email protected]> > Cc: [email protected] > Signed-off-by: Srinivas Kandagatla <[email protected]> > Signed-off-by: John Stultz <[email protected]> > --- > drivers/gpu/drm/bridge/adv7511/adv7511.h | 8 ++++++++ > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++-- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h > b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 161c923..c7002a0 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > @@ -16,6 +16,14 @@ > #include <drm/drm_crtc_helper.h> > #include <drm/drm_mipi_dsi.h> > > +#include <drm/drm_crtc_helper.h> Isn't it enough to include that header once ? :-) > + > +struct regmap; This isn't needed, the header includes linux/regmap.h. > +struct adv7511; > + > +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet); > +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet); You can move those two functions at the end, with all the other function declarations, and get rid of the forward declaration of struct adv7511. > #define ADV7511_REG_CHIP_REVISION 0x00 > #define ADV7511_REG_N0 0x01 > #define ADV7511_REG_N1 0x02 > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ec8fb2e..f8eb7f8 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -160,7 +160,7 @@ static void adv7511_set_colormap(struct adv7511 > *adv7511, bool enable, ADV7511_CSC_UPDATE_MODE, 0); > } > > -static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int > packet) > +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet) > { > if (packet & 0xff) > regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0, > @@ -175,7 +175,7 @@ static int adv7511_packet_enable(struct adv7511 > *adv7511, unsigned int packet) return 0; > } > > -static int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int > packet) > +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet) > { > if (packet & 0xff) > regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0, -- Regards, Laurent Pinchart
