Hi, Is there any concern on this patch?
Regards Alex On 08/25/2016 04:42 PM, Alex Shi wrote: > The obsolete commit 71abbbf85 want to introduce a dynamic cstates, > but it was removed for long time. Just left the nonsense deeper cstate > checking. > > Since all target_residency and exit_latency are going longer in deeper > idle state, no needs to waste some cpu cycle on useless seeking. > > Signed-off-by: Alex Shi <[email protected]> > To: [email protected] > Cc: [email protected] > Cc: Ulf Hansson <[email protected]> > Cc: Daniel Lezcano <[email protected]> > Cc: Alex Shi <[email protected]> > Cc: Rasmus Villemoes <[email protected]> > Cc: Arjan van de Ven <[email protected]> > Cc: Rik van Riel <[email protected]> > Cc: "Rafael J. Wysocki" <[email protected]> > --- > drivers/cpuidle/governors/menu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpuidle/governors/menu.c > b/drivers/cpuidle/governors/menu.c > index 03d38c2..bb58e2a 100644 > --- a/drivers/cpuidle/governors/menu.c > +++ b/drivers/cpuidle/governors/menu.c > @@ -358,9 +358,9 @@ static int menu_select(struct cpuidle_driver *drv, struct > cpuidle_device *dev) > if (s->disabled || su->disable) > continue; > if (s->target_residency > data->predicted_us) > - continue; > + break; > if (s->exit_latency > latency_req) > - continue; > + break; > > data->last_state_idx = i; > } >
