Hi, Is there any concern on this patch?
Regards Alex On 08/25/2016 04:42 PM, Alex Shi wrote: > This patch could reduce one branch in this function. Also > make the code more readble. > > Signed-off-by: Alex Shi <[email protected]> > Acked-by: Daniel Lezcano <[email protected]> > To: [email protected] > To: Greg Kroah-Hartman <[email protected]> > Cc: [email protected] > Cc: Ulf Hansson <[email protected]> > Cc: Daniel Lezcano <[email protected]> > --- > drivers/base/cpu.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index 691eeea..4c28e1a 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -371,12 +371,13 @@ int register_cpu(struct cpu *cpu, int num) > if (cpu->hotpluggable) > cpu->dev.groups = hotplugable_cpu_attr_groups; > error = device_register(&cpu->dev); > - if (!error) > - per_cpu(cpu_sys_devices, num) = &cpu->dev; > - if (!error) > - register_cpu_under_node(num, cpu_to_node(num)); > + if (error) > + return error; > > - return error; > + per_cpu(cpu_sys_devices, num) = &cpu->dev; > + register_cpu_under_node(num, cpu_to_node(num)); > + > + return 0; > } > > struct device *get_cpu_device(unsigned cpu) >
