On Wed, Sep 7, 2016 at 4:45 AM, SF Markus Elfring <[email protected]> wrote: >>> Would the following script (for the semantic patch language) >>> be useful enough for further development considerations? >>> >>> usage_of_kmalloc_array1-excerpt2.cocci: >>> @replacement2@ >>> expression count, pointer, target; >>> @@ >>> target = >>> - kmalloc(sizeof(*pointer) * (count) >>> + kmalloc_array(count, sizeof(*pointer) >>> , ...); >> >> Why don't you include the _exact_ script that you run? > > I showed only the "excerpt" above because of the current situation > that this single SmPL rule triggered the software change > which I suggested for the referenced source file. > > How do you think about to try a command out like the following > also in your development (or test) environment? > > elfring@Sonne:~/Projekte/Linux/next-patched> spatch.opt > ~/Projekte/Coccinelle/janitor/usage_of_kmalloc_array1-excerpt2.cocci > arch/x86/kernel/ksysfs.c
Fixing these kmalloc calls would be a nice thing to clean up everywhere. Since it is a mistake people may continue to make, I think it would make sense to add a coccinelle script that can do this to the existing coccinelle scripts in the kernel if one to do it does not already exist. That way, it will be part of the coccinelle checking that is automatically run on the kernel regularly. -Kees -- Kees Cook Nexus Security
