On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote:
> On Mon, Sep 19, 2016 at 11:56 AM, Linus Torvalds
> <torva...@linux-foundation.org> wrote:
> >> The only working (and fast) approach I could come up with was an ugly
> >> hack. It assumes that start_kernel() is in init/main.c.
> > That sounds entirely reasonable. Maybe somebody can come up with a
> > better and more general approach, but that sounds like a fine starting
> > point, and any incremental improvents can happen in the tree. So I'll
> > apply your patch (assuming it passes my basic testing, which I expect
> > it will).
> Hmm. Would you mind if I change the
> addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;"
> addr2line -fpie $objfile $hexaddr |
> sed "s; at $dir_prefix\(\./\)*; at ;"
> instead? There's two changes there: matching the " at " part (to just
> make the match stricter) but also matching any following "./" thing
> (which shows up for our include tree files, at least for me).
> With that, all the cases I threw at it looked pretty good.
> But the stricter matching might not matter, of course, and maybe there
> is some addr2line version that doesn't do that? So I'm checking here..
For some reason, I don't see the "./" for my include files. But
regardless, your changes look good to me.