Hi, On 21 September 2016 at 05:36, Thomas Gleixner <t...@linutronix.de> wrote: > On Sun, 18 Sep 2016, Baolin Wang wrote: > >> The patch 2 in this patchset adding tracepoints for alarmtimers will build >> failed on S390 platform, due to S390 defconfig did not define CONFIG_RTC_LIB >> macro to define the rtc_ktime_to_tm() function which is used in this patch. >> Thus we should add some ummy static inline functions in case CONFIG_RTC_LIB >> is not defined. > > I told you before that adding these inlines has the danger that we > introduce code which uses these functions in places which does not depend > on RTC_LIB. The resulting wreckage is going to be subtle and hard to debug.
Make sense. (By the way I am sorry I did not receive your previous comments in my mailbox and I checked again I found it was treated as spam.) > > This still stands and this patch is going nowhere. > > Thanks, > > tglx -- Baolin.wang Best Regards
