> On Mon, Oct 03, 2016 at 07:05:48AM +0000, Winkler, Tomas wrote: > > > > This patch is wrong, I though the comments were clear. All entry > > > points to find the device must be deleted before we commit to shutting > down the device. > > > > > > You need to figure out some other way to solve your problem. > > > > Please be more specific regarding flows you think will be wrong with > > this patch, you must agree that the current code is broken even w/o > > runtime pm. > > No, I don't agree. Accessing dev->name is OK after the device_del.
But you cannot assume that just dev->name is accessed and and runtime_pm breaks this assumption.. > > > What devicde_del does is fence off all sorts of ways to access the device, eg > sysfs files, bus registrations, etc, etc. That absolutely must be done before > calling tpm_suspend. But tpm2_shutdown is acceded via tpm_chip , we cannot call device_del before, this is just wrong from the Linux device mode perspective, we have to use other means to close the access to the device. Thanks Tomas
