On Thu 13-10-16 08:19:53, Vlastimil Babka wrote:
> On 10/12/2016 01:47 PM, Michal Hocko wrote:
[...]
> Acked-by: Vlastimil Babka <vba...@suse.cz>
Thanks!
>
> Small nitpick below.
>
> > @@ -1696,14 +1703,16 @@ enum compact_result try_to_compact_pages(gfp_t
> > gfp_mask, unsigned int order,
> > unsigned int alloc_flags, const struct alloc_context *ac,
> > enum compact_priority prio)
> > {
> > - int may_enter_fs = gfp_mask & __GFP_FS;
> > int may_perform_io = gfp_mask & __GFP_IO;
> > struct zoneref *z;
> > struct zone *zone;
> > enum compact_result rc = COMPACT_SKIPPED;
> >
> > - /* Check if the GFP flags allow compaction */
> > - if (!may_enter_fs || !may_perform_io)
> > + /*
> > + * Check if the GFP flags allow compaction - GFP_NOIO is really
> > + * tricky context because the migration might require IO and
>
> "and" ?
a leftover from a longer comment. s@ and@.@
Thanks for the review!
--
Michal Hocko
SUSE Labs
