On Fri, Oct 14, 2016 at 01:25:17AM +0530, Nadim Almas wrote:
>       Fixed coding style issue

Why the indentation?

> 
> Signed-off-by: Nadim Almas <nadim....@gmail.com>
> ---
> Changes in v2:
>   -Comment is taken from below line.

Huh?

> 
>  drivers/staging/ks7010/eap_packet.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/eap_packet.h 
> b/drivers/staging/ks7010/eap_packet.h
> index df7f760..90432ff 100644
> --- a/drivers/staging/ks7010/eap_packet.h
> +++ b/drivers/staging/ks7010/eap_packet.h
> @@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
>        * encrypt the Key field; 64-bit NTP timestamp MAY be used here
>        */
>       unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
> -     unsigned char key_iv[IEEE8021X_KEY_IV_LEN];     /* cryptographically 
> random number */
> +     unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
> +                     /* cryptographically random number */

Again, you put this below the line, which is not ok at all.  Does this
seem to be the way you would normally read code?

greg k-h

Reply via email to