Hi again, I forgot about this, and it's been a year. But isn't it time to upstream those pull-up fixes that Sylvain provided?
Cheers, Peter On 2015-09-24 16:47, Alexandre Belloni wrote: > Hi Peter, > > Thanks for the patch but you actually got beaten by Sylvain: > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368426.html > > On 24/09/2015 at 16:44:15 +0200, Peter Rosin wrote : >> From: Peter Rosin <p...@axentia.se> >> >> It seems pointless to pullup the tx line, but there is value in pulling >> up the rx line. >> >> Cc: sta...@vger.kernel.org >> Signed-off-by: Peter Rosin <p...@axentia.se> >> --- >> arch/arm/boot/dts/sama5d3.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi >> index 9e2444b07bce..304a40c5552a 100644 >> --- a/arch/arm/boot/dts/sama5d3.dtsi >> +++ b/arch/arm/boot/dts/sama5d3.dtsi >> @@ -545,8 +545,8 @@ >> dbgu { >> pinctrl_dbgu: dbgu-0 { >> atmel,pins = >> - <AT91_PIOB 30 >> AT91_PERIPH_A AT91_PINCTRL_NONE /* PB30 periph A */ >> - AT91_PIOB 31 >> AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB31 periph A with pullup */ >> + <AT91_PIOB 30 >> AT91_PERIPH_A AT91_PINCTRL_PULL_UP /* PB30 periph A with pullup */ >> + AT91_PIOB 31 >> AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PB31 periph A */ >> }; >> }; >> >> -- >> 1.7.10.4 >> >
