Hi Russell, 2016-11-04 21:23 GMT+09:00 Russell King - ARM Linux <[email protected]>: > On Fri, Nov 04, 2016 at 08:43:35PM +0900, Masahiro Yamada wrote: >> Documentation/CodingStyle recommends to use label names which say >> what the goto does or why the goto exists. >> >> Just in case, split it up into three labels because the CodingStyle >> says "one err bugs" is a common type of bug (although, I do not >> believe the current code includes such a bug). > > However, this has the effect of making the code unnecessarily more > complicated, which is a bad thing. Avoiding unnecessary code > complexity wins over style rules.
I thought this patch is stupid, but makes the code more straight-forward; the failure path only calls really needed iounmap/kfree() without exploiting that NULL input makes them no-op. -- Best Regards Masahiro Yamada
