On 07-11-16, 10:03, Viresh Kumar wrote: > On 04-11-16, 09:55, Markus Mayer wrote: > > From: Markus Mayer <mma...@broadcom.com> > > > > With the new attribute type, it is possible to create write-only > > CPUfreq attributes. > > > > Signed-off-by: Markus Mayer <mma...@broadcom.com> > > --- > > include/linux/cpufreq.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > > index 5fa55fc..ed09930 100644 > > --- a/include/linux/cpufreq.h > > +++ b/include/linux/cpufreq.h > > @@ -234,6 +234,10 @@ __ATTR(_name, _perm, show_##_name, NULL) > > static struct freq_attr _name = \ > > __ATTR(_name, 0644, show_##_name, store_##_name) > > > > +#define cpufreq_freq_attr_wr_perm(_name, _perm) \ > > shouldn't this be _wo_perm ? > > Also, I wouldn't mind doing this in the second patch itself.
Also there is no need to define a _perm variant here, and then you can avoid sending 0200 as argument as well. -- viresh
