taos_probe() calls i2c_smbus_write_byte() to select the control
register, however there are no subsequent calls to
i2c_smbus_read_byte(). The write call is unnecessary and is removed by
this patch.

Verified that the driver still functions correctly using a TSL2581
hooked up to a Raspberry Pi 2.

Signed-off-by: Brian Masney <masn...@onstation.org>
---
 drivers/staging/iio/light/tsl2583.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/iio/light/tsl2583.c 
b/drivers/staging/iio/light/tsl2583.c
index 5a32102..449506b 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -788,14 +788,6 @@ static int taos_probe(struct i2c_client *clientp,
                return -EINVAL;
        }
 
-       ret = i2c_smbus_write_byte(clientp, (TSL258X_CMD_REG | TSL258X_CNTRL));
-       if (ret < 0) {
-               dev_err(&clientp->dev,
-                       "i2c_smbus_write_byte() to cmd reg failed in 
taos_probe(), err = %d\n",
-                       ret);
-               return ret;
-       }
-
        indio_dev->info = &tsl2583_info;
        indio_dev->channels = tsl2583_channels;
        indio_dev->num_channels = ARRAY_SIZE(tsl2583_channels);
-- 
2.7.4

Reply via email to