On Fri, Nov 11, 2016 at 08:04:26PM +0100, Julia Lawall wrote: > The function usnic_ib_qp_grp_get_chunk only returns an ERR_PTR value or a > valid pointer, never NULL. The same is true of get_qp_res_chunk, which > just returns the result of calling usnic_ib_qp_grp_get_chunk. Simplify > IS_ERR_OR_NULL to IS_ERR in both cases. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression t,e; > @@ > > t = \(usnic_ib_qp_grp_get_chunk(...)\|get_qp_res_chunk(...)\) > ... when != t=e > - IS_ERR_OR_NULL(t) > + IS_ERR(t) > > @@ > expression t,e,e1; > @@ > > t = \(usnic_ib_qp_grp_get_chunk(...)\|get_qp_res_chunk(...)\) > ... when != t=e > ?- t ? PTR_ERR(t) : e1 > + PTR_ERR(t) > ... when any > // </smpl> > > Signed-off-by: Julia Lawall <[email protected]>
Thanks, Julia. Reviewed-by: Leon Romanovsky <[email protected]>
signature.asc
Description: PGP signature
