Hi Boris, 2016-11-28 1:16 GMT+09:00 Boris Brezillon <[email protected]>: > > If you follow my suggestions of definition function pointers, you'll > just have to add a function pointer to the denali_caps struct: > > void (*setup_dma)(struct denali_nand_info *denali, int op); >
This is possible because both 32B and 64B variants have the same function prototype. However, I am not keen on doing so for ecc_handle(), so, at this moment, I am not keen on doing so only for setup_dma() either. If I see more cases that fit in callback handler approach, I will think about switching to it with consistency. -- Best Regards Masahiro Yamada
