Hi Hans,
On 2016년 12월 19일 09:07, Hans de Goede wrote:
> Nothing was setting info->otg.cable, so the extcon_get_cable_state_
> calls on it would always return -EINVAL.
>
> This commit fixes this by actually setting info->otg.cable using the new
> extcon_get_extcon_dev_by_cable_id function.
>
> This commit also makes failing to register the extcon notifier for the
> USB_HOST cable an error rather then a warning, because we MUST have this
> notfier to properly disable the VBUS path when in host mode so that we're
> not drawing current from the 5V boost converter which is supplying power
> to the otg port when in host mode.
>
> Signed-off-by: Hans de Goede <[email protected]>
> ---
> drivers/power/supply/axp288_charger.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/power/supply/axp288_charger.c
> b/drivers/power/supply/axp288_charger.c
> index 08a5dba..2b95db2 100644
> --- a/drivers/power/supply/axp288_charger.c
> +++ b/drivers/power/supply/axp288_charger.c
> @@ -833,6 +833,12 @@ static int axp288_charger_probe(struct platform_device
> *pdev)
> return -EPROBE_DEFER;
> }
>
> + info->otg.cable = extcon_get_extcon_dev_by_cable_id(EXTCON_USB_HOST);
> + if (info->otg.cable == NULL) {
> + dev_dbg(dev, "EXTCON_USB_HOST is not ready, probe deferred\n");
> + return -EPROBE_DEFER;
> + }
> +
I replied my opinion of extcon_get_extcon_dev_by_cable_id from patch1.
If you possible, I think that you better to use the id_table which
includes the correct name of extcon device which support the EXTCON_USB_HOST.
When changing the hardware design, I think you can add the new device_id
with new extcon device name.
> platform_set_drvdata(pdev, info);
> mutex_init(&info->lock);
>
> @@ -867,12 +873,12 @@ static int axp288_charger_probe(struct platform_device
> *pdev)
> info->otg.id_nb.notifier_call = axp288_charger_handle_otg_evt;
> ret = devm_extcon_register_notifier(dev, info->otg.cable,
> EXTCON_USB_HOST, &info->otg.id_nb);
> - if (ret)
> - dev_warn(&pdev->dev, "failed to register otg notifier\n");
> -
> - if (info->otg.cable)
> - info->otg.id_short = extcon_get_cable_state_(
> - info->otg.cable, EXTCON_USB_HOST);
> + if (ret) {
> + dev_err(dev, "failed to register EXTCON_USB_HOST notifier\n");
> + return ret;
> + }
> + info->otg.id_short = extcon_get_cable_state_(info->otg.cable,
> + EXTCON_USB_HOST);
>
> /* Register charger interrupts */
> for (i = 0; i < CHRG_INTR_END; i++) {
>
--
Regards,
Chanwoo Choi
