On Wed, Dec 28, 2016 at 12:28 AM, Randy Dunlap <[email protected]> wrote: > From: Randy Dunlap <[email protected]> > > Fix build errors when I2C=m and SURFACE_3_BUTTON=y. > The driver uses i2c interfaces so it should depend on I2C. > > drivers/built-in.o: In function `surface3_driver_init': > surface3_button.c:(.init.text+0x75cb0): undefined reference to > `i2c_register_driver' > drivers/built-in.o: In function `surface3_driver_exit': > surface3_button.c:(.exit.text+0x31a8): undefined reference to `i2c_del_driver' > > Fixes: 1a64b719d3ae (platform/x86: Introduce button support for the Surface 3) >
Pushed to fixes. Thanks! > Signed-off-by: Randy Dunlap <[email protected]> > Reported-by: kbuild test robot <[email protected]> > Cc: Benjamin Tissoires <[email protected]> > Cc: [email protected] > Cc: Darren Hart <[email protected]> > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- lnx-410-rc1.orig/drivers/platform/x86/Kconfig > +++ lnx-410-rc1/drivers/platform/x86/Kconfig > @@ -1034,7 +1034,7 @@ config SURFACE_PRO3_BUTTON > > config SURFACE_3_BUTTON > tristate "Power/home/volume buttons driver for Microsoft Surface 3 > tablet" > - depends on ACPI && KEYBOARD_GPIO > + depends on ACPI && KEYBOARD_GPIO && I2C > ---help--- > This driver handles the power/home/volume buttons on the Microsoft > Surface 3 tablet. > -- With Best Regards, Andy Shevchenko
