On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck <[email protected]> wrote: > The 'ret' variable in iTCO_wdt_init_module() does not add any value; > drop it.
Perhaps 'err', otherwise: Reviewed-by: Andy Shevchenko <[email protected]> > > Signed-off-by: Guenter Roeck <[email protected]> > --- > drivers/watchdog/iTCO_wdt.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c > index ad29ae03a30b..fc7712112412 100644 > --- a/drivers/watchdog/iTCO_wdt.c > +++ b/drivers/watchdog/iTCO_wdt.c > @@ -612,15 +612,9 @@ static struct platform_driver iTCO_wdt_driver = { > > static int __init iTCO_wdt_init_module(void) > { > - int err; > - > pr_info("Intel TCO WatchDog Timer Driver v%s\n", DRV_VERSION); > > - err = platform_driver_register(&iTCO_wdt_driver); > - if (err) > - return err; > - > - return 0; > + return platform_driver_register(&iTCO_wdt_driver); > } > > static void __exit iTCO_wdt_cleanup_module(void) > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko
