On Tue, Jan 10, 2017 at 3:46 PM, Pavel Machek <[email protected]> wrote: > Hi! > >> +static void serdev_ctrl_release(struct device *dev) >> +{ >> + struct serdev_controller *ctrl = to_serdev_controller(dev); >> + ida_simple_remove(&ctrl_ida, ctrl->nr); >> + kfree(ctrl); >> +} > > Would it make sense to do something like to_serdev_controller(dev) = > NULL; there?
That would be the same as adding "ctrl = NULL;" which would be pointless. The struct device is embedded into serdev_controller. Rob
