* Paul E. McKenney <paul...@linux.vnet.ibm.com> wrote:
> > > + */
> > > +#ifdef CONFIG_PPC
> > > +#define smp_mb__after_unlock_lock() smp_mb() /* Full ordering for
> > > lock. */
> > > +#else /* #ifdef CONFIG_PPC */
> > > +#define smp_mb__after_unlock_lock() do { } while (0)
> > > +#endif /* #else #ifdef CONFIG_PPC */
> >
> > Yeah, so I realize that this was pre-existing code, but putting CONFIG_$ARCH
> > #ifdefs into generic headers is generally frowned upon.
> >
> > The canonical approach would be either to define a helper Kconfig variable
> > that
> > can be set by PPC (but other architectures don't need to set it), or to
> > expose a
> > suitable macro (function) for architectures to define in their barrier.h
> > arch
> > header file.
>
> Very well, I will add a separate commit for this. 4.11 OK?
Sure!
Thanks,
Ingo
