On Fri, Feb 3, 2017 at 4:02 PM, Jan Kiszka <[email protected]> wrote: > On 2017-01-30 23:28, Sudip Mukherjee wrote: >> From: Sudip Mukherjee <[email protected]> >> >> Add the serial driver for the Exar chips. And also register the >> platform device for the GPIO provided by the Exar chips. > > "Also" means you are doing two things in one patch - was this already > discussed and accepted in previous review rounds? If so, ignore my > comment, but I would have asked for two patches, one that just > translates the existing code and another that adds this new feature.
Since it's already in Greg's tty-next, no point to fix anymore this particular part. However, you are right that few lines of code might be split to a separate change. >> +/* >> + * Probe module for 8250/16550-type Exar chips PCI serial ports. >> + * >> + * Based on drivers/tty/serial/8250/8250_pci.c, >> + * >> + * Copyright (C) 2017 Sudip Mukherjee, All Rights Reserved. > > It's legally cleaner to carry over the copyright notice from the > original file, unless you rewrote everything (unlikely on first glance). > You may still add yours to the list for the significant contributions. > > BTW, are you personally the copyright holder or your employer Codethink? > Depends on your contractual situation, but the former is less common. This is good comment and I think it needs to be addressed (as a separate change due to above). -- With Best Regards, Andy Shevchenko
