On (02/09/17 11:23), Yisheng Xie wrote:
> The class index and fullness group are not encoded in
> (first)page->mapping any more, after commit 3783689a1aa8 ("zsmalloc:
> introduce zspage structure"). Instead, they are store in struct zspage.
>
> Cc: Minchan Kim <minc...@kernel.org>
> Cc: Sergey Senozhatsky <sergey.senozhat...@gmail.com>
> Cc: Nitin Gupta <ngu...@vflare.org>
> Cc: Hanjun Guo <guohan...@huawei.com>
> Signed-off-by: Yisheng Xie <xieyishe...@huawei.com>
no objections from my side.
Reviewed-by: Sergey Senozhatsky <sergey.senozhat...@gmail.com>
a side note - may be we don't need this comment at all.
the code looks like this:
/*
* A zspage's class index and fullness group
* are stored in struct zspage.
*/
#define FULLNESS_BITS 2
#define CLASS_BITS 8
#define ISOLATED_BITS 3
#define MAGIC_VAL_BITS 8
struct zspage {
struct {
unsigned int fullness:FULLNESS_BITS;
unsigned int class:CLASS_BITS;
unsigned int isolated:ISOLATED_BITS;
unsigned int magic:MAGIC_VAL_BITS;
};
unsigned int inuse;
unsigned int freeobj;
struct page *first_page;
struct list_head list; /* fullness list */
#ifdef CONFIG_COMPACTION
rwlock_t lock;
#endif
};
so, basically, the comment just "repeats" the next 5 lines.
but, like I said, that's just a side note.
-ss
