On 02/06, Dmitry Torokhov wrote: > On Mon, Jan 30, 2017 at 04:57:13PM -0800, Dmitry Torokhov wrote: > > When converting a driver to managed resources it is desirable to be able to > > manage all resources in the same fashion. This change allows managing clock > > prepared and enabled state in the same way we manage many other resources. > > > > This adds the following managed APIs: > > > > - devm_clk_prepare()/devm_clk_unprepare(); > > - devm_clk_prepare_enable()/devm_clk_disable_unprepare(). > > > > Reviewed-by: Guenter Roeck <li...@roeck-us.net> > > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> > > It would be awesome if we could get it into 4.11...
I'd prefer we didn't do this. Instead, make clk_put() drop any prepare or enables that were done via that clk pointer. Mike started to do this before[1], but we have some code that assumes it can do: clk = clk_get(...) clk_prepare_enable(clk) clk_put(clk) and have the clk stay on. Those would need to be changed. We would also need Russell's approval to update the clk_put() documentation to describe this change in behavior. [1] http://lkml.kernel.org/r/1438974570-20812-1-git-send-email-mturque...@baylibre.com -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project