On Tue, 13 Mar 2007 16:30:27 -0700 Jeremy Fitzhardinge wrote: > smp_call_function and smp_call_function_single are almost complete > duplicates of the same logic. This patch combines them by > implementing them in terms of the more general > smp_call_function_mask().
The kernel-doc is still not quite correct. Patch below applies on top of this patch from Jeremy. --- From: Randy Dunlap <[EMAIL PROTECTED]> Clean up arch/i386/kernel/smp.c after the Xen pv_ops patches for smp_call_function variants. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- arch/i386/kernel/smp.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) --- linux-2621-rc3.orig/arch/i386/kernel/smp.c +++ linux-2621-rc3/arch/i386/kernel/smp.c @@ -517,14 +517,14 @@ static struct call_data_struct *call_dat /** - * smp_call_function_mask(): Run a function on a set of other CPUs. + * smp_call_function_mask - Run a function on a set of other CPUs. * @mask: The set of cpus to run on. Must not include the current cpu. * @func: The function to run. This must be fast and non-blocking. * @info: An arbitrary pointer to pass to the function. * @wait: If true, wait (atomically) until function has completed on other CPUs. * * Returns 0 on success, else a negative status code. Does not return until - * remote CPUs are nearly ready to execute <<func>> or are or have finished. + * remote CPUs are nearly ready to execute func() or are or have finished. * * You must not call this function with disabled interrupts or from a * hardware interrupt handler or from a bottom half handler. @@ -583,14 +583,14 @@ int smp_call_function_mask(cpumask_t mas } /** - * smp_call_function(): Run a function on all other CPUs. + * smp_call_function - Run a function on all other CPUs. * @func: The function to run. This must be fast and non-blocking. * @info: An arbitrary pointer to pass to the function. * @nonatomic: currently unused. * @wait: If true, wait (atomically) until function has completed on other CPUs. * * Returns 0 on success, else a negative status code. Does not return until - * remote CPUs are nearly ready to execute <<func>> or are or have executed. + * remote CPUs are nearly ready to execute func() or are or have executed. * * You must not call this function with disabled interrupts or from a * hardware interrupt handler or from a bottom half handler. @@ -602,8 +602,9 @@ int smp_call_function(void (*func) (void } EXPORT_SYMBOL(smp_call_function); -/* +/** * smp_call_function_single - Run a function on another CPU + * @cpu: The target (destination) CPU number. * @func: The function to run. This must be fast and non-blocking. * @info: An arbitrary pointer to pass to the function. * @nonatomic: Currently unused. @@ -611,7 +612,7 @@ EXPORT_SYMBOL(smp_call_function); * * Retrurns 0 on success, else a negative status code. * - * Does not return until the remote CPU is nearly ready to execute <func> + * Does not return until the remote CPU is nearly ready to execute func() * or is or has executed. */ int smp_call_function_single(int cpu, void (*func) (void *info), void *info, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
