Hi Arnaldo, On Wed, Mar 8, 2017 at 12:28 AM, Arnaldo Carvalho de Melo <[email protected]> wrote: > Em Wed, Mar 08, 2017 at 12:08:30AM +0900, Namhyung Kim escreveu: >> The -q/--quiet option is to suppress any message. Sometimes users just >> want to run the command and it can be used for that case. > > <SNIP> > >> +++ b/tools/perf/builtin-buildid-cache.c >> @@ -311,6 +311,7 @@ int cmd_buildid_cache(int argc, const char **argv, >> OPT_INCR('v', "verbose", &verbose, "be more verbose"), >> + OPT_BOOLEAN('q', "quiet", &quiet, "Do not show any message"), >> OPT_END() >> }; >> const char * const buildid_cache_usage[] = { >> @@ -326,6 +327,9 @@ int cmd_buildid_cache(int argc, const char **argv, >> >> + if (quiet) >> + perf_quiet_option(); >> + > > Hey, I see that this is done lots of times, can't we use that parent > option stuff? Or some fallback we can have in perf's main() for thing > like this?
I thought about it. But perf main option handling is different from command options. Also it needs to be called after option parsing is done to overwrite 'verbose' properly. Thanks, Namhyung
